next_posts_link outputs a trailing question mark

[charle97]

next_posts_link outputs a trailing question mark on any page 2 when using clean urls.

[rob1n]

Yep. Reproduced.

[charle97]

commenting out the line

$qstr = remove_query_arg('paged', $qstr); for query style

in get_pagenum_link seems to fix it. i don't know how it affects the other permalink styles.

[charle97]

further isolated the problem to add_query_arg.

specifically line 797 for query style and line 801 for clean urls:

791 	    if (strpos($uri, '?') !== false) {
792 	        $parts = explode('?', $uri, 2);
793 	        if ( 1 == count($parts) ) {
794 	            $base = '?';
795 	            $query = $parts[0];
796 	        } else {
797 	            $base = $parts[0] . '?';
798 	            $query = $parts[1];
799 	        }
800 	    } elseif (!empty($protocol) || strpos($uri, '/') !== false) {
801 	        $base = $uri . '?';
802 	        $query = '';
803 	    } else {
804 	        $base = '';
805 	        $query = $uri;
806 	    }

[rob1n]

(In [5267]) trim() question marks *after* concatenating the string. fixes #4134