Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41363, comment 4


Ignore:
Timestamp:
02/15/2022 12:56:35 PM (2 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41363, comment 4

    initial v1  
    44Not really, I meant that the function itself already has a description to clarify its purpose, so I don't see a significant benefit in duplicating it in other instances. So unless there is something to improve in the function description, I think this ticket can be closed.
    55
    6 I guess the point of the ticket was that in this particular file, the `send_origin_headers()` call has a comment while `nocache_headers()` does not have it, which might seem a bit inconsistent. Then again, if the code is mostly self-documenting, I don't think it's necessary to have a comment for every single function call. Note that the comment on `send_origin_headers()` does not just duplicate the function description but provides some more context.
     6I guess the point of the ticket was that in this particular file, the `send_origin_headers()` call has a comment while `nocache_headers()` does not, which might seem a bit inconsistent. Then again, if the code is mostly self-documenting, I don't think it's necessary to add a comment for every single function call. Note that the `send_origin_headers()` comment does not just duplicate the function description but provides some more context.