WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#41377 closed defect (bug) (fixed)

Add @access entries for $admin_header_callback and $admin_image_div_callback properties in Custom_Image_Header

Reported by: rushabh4486 Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords:
Focuses: docs Cc:

Description

Needs documents improvement in wp-admin/custom header.php

Attachments (1)

41377.patch (434 bytes) - added by rushabh4486 4 years ago.
Needs documents improvement!

Download all attachments as: .zip

Change History (6)

@rushabh4486
4 years ago

Needs documents improvement!

#1 @rushabh4486
4 years ago

I have attached the patch.

#2 @SergeyBiryukov
4 years ago

  • Component changed from Editor to Customize
  • Milestone changed from Awaiting Review to 4.9

#3 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41100:

Docs: Add @access entries for $admin_header_callback and $admin_image_div_callback properties in Custom_Image_Header and Custom_Background.

Props rushabh4486.
Fixes #41377.

#4 @westonruter
4 years ago

Note that the @access is redundant in classes as of PHP 5 (where previously only var was supported). I'm supporting that such @access tags be removed from class members in the future. See more around https://wordpress.slack.com/archives/C02RP4WU5/p1495224872995687

The @access tag need only be used for global functions and global variables that don't have a way to specify their visibility in the language itself.

#5 @SergeyBiryukov
4 years ago

  • Summary changed from Needs documents improvement! to Add @access entries for $admin_header_callback and $admin_image_div_callback properties in Custom_Image_Header
Note: See TracTickets for help on using tickets.