WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 7 days ago

#41388 new defect (bug)

Insert Media window does not remember state for custom tabs, iframe bug

Reported by: angel8888 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: critical Version: 4.8
Component: General Keywords: needs-patch
Focuses: Cc:

Description

Hi! I use Edd plugin (easy digital downloads) and Amazon S3 plugin (https://easydigitaldownloads.com/downloads/amazon-s3/). After WordPress update to 4.8, I have encounted problem with filling my downloadable files.
I upload them via cyberduck and then create 5 instances of “add new price” – push “upload to file”, then – “Amazon S3 Library”. Before update I had to do so for first price – but next 4 prices pulled the path from the previous price – that was much easier and time-saving. Now – I need to enter whole path each time for each price. When I rollback to wordpress 4.7.5 – problem gone. Here is video that will describe my problem more clear – https://www.youtube.com/watch?v=GeaJrLYtMZI&authuser=0
I asked for help EDD team, but they say “Unfortunately that issue is caused by a change in WordPress itself so is not something we can affect, sorry. It’s possible it was an accidental change with WordPress that will be resolved in a new update by the core WordPress team.”

Change History (8)

#1 follow-up: @SergeyBiryukov
4 months ago

  • Keywords reporter-feedback added

Hi @angel8888, welcome to WordPress Trac!

I asked for help EDD team, but they say “Unfortunately that issue is caused by a change in WordPress itself so is not something we can affect, sorry. It’s possible it was an accidental change with WordPress that will be resolved in a new update by the core WordPress team.”

Could they elaborate on that and point to the exact change that caused the issue?

#2 in reply to: ↑ 1 @angel8888
4 months ago

Asked them for help, waiting for response.

Replying to SergeyBiryukov:

Hi @angel8888, welcome to WordPress Trac!

I asked for help EDD team, but they say “Unfortunately that issue is caused by a change in WordPress itself so is not something we can affect, sorry. It’s possible it was an accidental change with WordPress that will be resolved in a new update by the core WordPress team.”

Could they elaborate on that and point to the exact change that caused the issue?

#3 @mordauk
4 months ago

  • Summary changed from Resets path since 4.8 to Insert Media window does not remember state for custom tabs

We don't know what change exactly caused the issue, we just know what the behavior is.

In earlier versions media frames persisted, now they don't. For example, Easy Digital Downloads has an integration with Amazon S3 (what angel8888 mentioned above) that uses an iframe to pull in files from Amazon S3. Prior to a recent change, a site owner could open the media library from a post edit screen, navigate to the file they wished to use, insert it into the post (resulting in the media window being closed), then re-open the add media screen and the media library would be in the same state as it was after inserting the first file. Now, however, the media window resets to the default state each time it is opened instead of remembering the user's previous tab.

The tabs we add are done using the standard method that is shown here https://codex.wordpress.org/Function_Reference/wp_iframe

It seems the problem with losing the previous state only occurs with custom tabs. The default media tabs remember their state fine.

#4 @angel8888
3 months ago

Any news or fix? I did rollback to 4.7.5 to have ability to work, but hope to see fix soon.

#5 @angel8888
3 months ago

  • Keywords reporter-feedback removed

#6 @angel8888
8 weeks ago

  • Keywords needs-patch added
  • Severity changed from normal to critical

Hi! Please, can you fix that bug? I am still on 4.7.5...

#7 @angel8888
7 days ago

  • Summary changed from Insert Media window does not remember state for custom tabs to Insert Media window does not remember state for custom tabs, iframe bug

Please, can you revert back iframe behavior?

This ticket was mentioned in Slack in #core-media by desrosj. View the logs.


7 days ago

Note: See TracTickets for help on using tickets.