| 1 | | The Custom HTML widget (#40907) applies the `widget_text` filters on its content to ensure that when a user moves HTML from a Text widget over to a Custom HTML widget, it will get all of the same filters applied. See [41086]. There are still `widget_text_content` and `widget_custom_html_content` filters that apply to the Text widget and Custom HTML widget respectively, but they share this same `widget_text` filter that has been around since WP 2.3.0. |
| | 1 | When TinyMCE was introduced to the Text widget in #35243, the `filter` prop was overloaded to take a truthy `content` string value, in addition to what it had formerly as a simple boolean. The `filter=content` was taken to mean that the content filters should apply (`widget_text_content`), in addition to just `wpautop`. When `filter=true` then just `wpautop` would apply, and when `filter=false` then no `wpautop` would apply. The `filter=content` prop was then also used as a signal for whether or not the visual editor should be loaded. |
| | 2 | |
| | 3 | '''Problem:''' Overloading the `filter` boolean to take this tertiary state, however, could cause problems for plugins that look explicitly for a `filter=true` value in existing plugins that filter`widget_text`. |
| | 4 | |
| | 5 | In #40951 there was a `legacy` boolean prop added to modified Text widgets, to indicate that the visual editor should ''not'' be loaded: when `legacy=true` then the new TinyMCE editor would be displayed. This new property was added since the `filter` property couldn't be overloaded yet further. |
| | 6 | |
| | 7 | Nevertheless, the overloading of the `filter` property to be boolean and also a string of `content` could be undone, and the `legacy` property added in #40951 could change from being a simple single-value flag to instead be a boolean `visual` property. A `visual=true` property would indicate that TinyMCE should be loaded, whereas `visual=false` would indicate that it should not be loaded. If `visual=null` when the form is loaded, then the `is_legacy_instance` logic is used to set the initial value. |
| | 8 | |
| | 9 | Furthermore, the Custom HTML widget (#40907) applies the `widget_text` filters on its content to ensure that when a user moves HTML from a Text widget over to a Custom HTML widget, it will get all of the same filters applied. See [41086]. There are still `widget_text_content` and `widget_custom_html_content` filters that apply to the Text widget and Custom HTML widget respectively, but they share this same `widget_text` filter that has been around since WP 2.3.0. |