TinyMCE: Images with link and caption look "broken" when selected

[azaozz]

Happens when the image is set to display: block. That interferes with the zero width chars that are inserted when a link is selected.

[azaozz]

In 41408.patch: fix styling for images that have link and caption.

Thinking this should be considered for 4.8.1 as it is an annoying visual regression/bug. However it will need some testing in different themes as the CSS selectors are more specific in order to override themes that also set images with captions to display: block (that was already in the WP default editor styles, there was no need to repeat in themes).

[pento]

Patch looks good.

Out of scope for this ticket, but it seems like there should be some sort of selector on dl.wp-caption when the image or caption are selected, and appropriate styling to show that you've selected part of a larger object.

[westonruter]

In 41141:

TinyMCE: Fix styling of selected state for linked images containing captions.

Props azaozz.
Fixes #41408.

[westonruter]

In 41142:

TinyMCE: Fix styling of selected state for linked images containing captions.

Merges [41141] onto 4.8 branch.
Props azaozz.
Fixes #41408 for 4.8.1.

[azaozz]

Replying to pento:

...there should be some sort of selector on dl.wp-caption when the image or caption are selected, and appropriate styling to show that you've selected part of a larger object.

Yeah, that would be nice. Lets try it for 4.9, opened #41430 as a follow-up.