Opened 7 years ago
Closed 7 years ago
#41410 closed defect (bug) (fixed)
Set `'filter' => 'content'` on starter content "business info" widget
Reported by: | dlh | Owned by: | westonruter |
---|---|---|---|
Milestone: | 4.8.1 | Priority: | normal |
Severity: | normal | Version: | 4.8 |
Component: | Customize | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
The text_business_info
starter content widget currently prompts the user to move the content into the Custom HTML widget. To my eyes, neither the legacy text widget nor the HTML widget provide as good an editing experience for that widget's content as a TinyMCE-enabled text widget (see screenshots). So, the attached patch would set 'filter' => 'content'
on the widget to ensure it uses TinyMCE.
Attachments (5)
Change History (13)
#2
follow-up:
↓ 3
@
7 years ago
- Milestone changed from Awaiting Review to 4.8.1
- Owner set to westonruter
- Status changed from new to accepted
- Version changed from trunk to 4.8
@dlh Wow, excellent find! I wonder if fundamentally instead of setting visual
to true
if we should instead change the text
to cause it to such that legacy mode would not have been triggered to begin with? In 41410.3.diff you can see what I mean. Strictly 'visual' => true
(or 'filter' => 'content'
) is even not necessary here because the text
would not match is_legacy_instance
anyway.
#3
in reply to:
↑ 2
@
7 years ago
Replying to westonruter:
@dlh I wonder if fundamentally instead of setting
visual
totrue
if we should instead change thetext
to cause it to such that legacy mode would not have been triggered to begin with?
That works, too. I'm not sure I have a preference. It does seem like the text
of 41410.3.diff is closer to what gets saved in the text widget if you try to manually recreate the content of the starter widget, which might be another reason to make the change.
41410.2.diff is a version with
'visual' => true
, as proposed in #41394.