WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#41410 closed defect (bug) (fixed)

Set `'filter' => 'content'` on starter content "business info" widget

Reported by: dlh Owned by: westonruter
Milestone: 4.8.1 Priority: normal
Severity: normal Version: 4.8
Component: Customize Keywords: has-patch commit fixed-major
Focuses: Cc:
PR Number:

Description

The text_business_info starter content widget currently prompts the user to move the content into the Custom HTML widget. To my eyes, neither the legacy text widget nor the HTML widget provide as good an editing experience for that widget's content as a TinyMCE-enabled text widget (see screenshots). So, the attached patch would set 'filter' => 'content' on the widget to ensure it uses TinyMCE.

Attachments (5)

41410.diff (515 bytes) - added by dlh 2 years ago.
Screen Shot 2017-07-23 at 12.50.41 AM.png (168.2 KB) - added by dlh 2 years ago.
Screen Shot 2017-07-23 at 12.59.41 AM.png (132.6 KB) - added by dlh 2 years ago.
41410.2.diff (626 bytes) - added by dlh 2 years ago.
41410.3.diff (1.7 KB) - added by westonruter 2 years ago.

Download all attachments as: .zip

Change History (13)

@dlh
2 years ago

@dlh
2 years ago

#1 @dlh
2 years ago

41410.2.diff is a version with 'visual' => true, as proposed in #41394.

@westonruter
2 years ago

#2 follow-up: @westonruter
2 years ago

  • Milestone changed from Awaiting Review to 4.8.1
  • Owner set to westonruter
  • Status changed from new to accepted
  • Version changed from trunk to 4.8

@dlh Wow, excellent find! I wonder if fundamentally instead of setting visual to true if we should instead change the text to cause it to such that legacy mode would not have been triggered to begin with? In 41410.3.diff you can see what I mean. Strictly 'visual' => true (or 'filter' => 'content') is even not necessary here because the text would not match is_legacy_instance anyway.

#3 in reply to: ↑ 2 @dlh
2 years ago

Replying to westonruter:

@dlh I wonder if fundamentally instead of setting visual to true if we should instead change the text to cause it to such that legacy mode would not have been triggered to begin with?

That works, too. I'm not sure I have a preference. It does seem like the text of 41410.3.diff is closer to what gets saved in the text widget if you try to manually recreate the content of the starter widget, which might be another reason to make the change.

#4 @westonruter
2 years ago

  • Keywords commit added

#5 @westonruter
2 years ago

Depends on #41394.

#6 @westonruter
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41136:

Customize: Update Text widget starter content to utilize visual mode.

Amends [38991].
Props dlh, westonruter.
See #35243, #38114.
Fixes #41410.

#7 @westonruter
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Re-opening for 4.8.1

#8 @westonruter
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41137:

Customize: Update Text widget starter content to utilize visual mode.

Merges [41136] onto 4.8 branch.
Amends [38991].
Props dlh, westonruter.
See #35243, #38114.
Fixes #41410 for 4.8.1.

Note: See TracTickets for help on using tickets.