WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#41415 closed defect (bug) (fixed)

Possible typo in unit test?

Reported by: redrambles's profile redrambles Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: Cc:

Description

Hi there! Just looking at unit tests in an effort to better understand how they work - and came across this. Not sure if it's relevant - but here you go!

​Screenshot

Change History (3)

#1 @redrambles
7 years ago

In tests/functions/allowedProtocols.php

#2 @SergeyBiryukov
7 years ago

  • Milestone changed from Awaiting Review to 4.9

Good catch! It's a test for wp_allowed_protocols(), so the URL is not actually used there, only the protocol is, that's why the typo didn't cause the test to fail. Introduced in [38685].

#3 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41124:

Tests: Fix typo in Tests_Functions_AllowedProtocols::data_example_urls().

Props redrambles.
Fixes #41415.

Note: See TracTickets for help on using tickets.