WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#41420 closed defect (bug) (wontfix)

Add @access entry for WP_Comments_List_Table::column_default()

Reported by: kakshak Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.8
Component: Comments Keywords: has-patch
Focuses: docs, administration Cc:

Description

The public function column_default() is defined but access public is not defined in that function.

Attachments (1)

41420.patch (394 bytes) - added by kakshak 3 years ago.

Download all attachments as: .zip

Change History (13)

@kakshak
3 years ago

#1 @kakshak
3 years ago

  • Keywords has-patch needs-testing added

#2 @afercia
3 years ago

  • Focuses accessibility removed
  • Keywords has-patch needs-testing removed

Thanks @kakshak! Removing the "accessibility" focus since it's used for issues related to web content accessibility.
I'd add this method (and several other ones in this file) completely miss a summary.

#3 @kakshak
3 years ago

Thanks, @afercia! Correcting me that actual meaning of "accessibility" focus. But why you have removed "has-patch" and "needs-testing" keywords?

#4 @afercia
3 years ago

  • Keywords has-patch needs-testing added

Sorry, my mistake. Actually, I think I haven't touched the keywords, maybe a side effect because we were editing the ticket at the same time.

#5 @kakshak
3 years ago

It's okay. No problem.

#6 @SergeyBiryukov
3 years ago

  • Component changed from General to Comments
  • Focuses administration added
  • Keywords needs-testing removed

#7 @GaryJ
3 years ago

  • Resolution set to wontfix
  • Status changed from new to closed

Closing as wontfix, since all the @access public annotations have been removed - see #41452.

#8 @netweb
3 years ago

  • Milestone Awaiting Review deleted

#9 @kakshak
3 years ago

  • Resolution wontfix deleted
  • Status changed from closed to reopened

#10 @kakshak
3 years ago

Hello @GaryJ,
Why you have closed this ticket? Because what file you are talking that is different file.
Thank you,
Kakshak

#11 @afercia
3 years ago

  • Resolution set to wontfix
  • Status changed from reopened to closed

@kakshak see the two changesets (committed a few hours ago) related to the ticket @GaryJ mentioned:
https://core.trac.wordpress.org/changeset/41161
https://core.trac.wordpress.org/changeset/41162

#12 @SergeyBiryukov
3 years ago

  • Summary changed from Documantation updation required to Add @access entry for WP_Comments_List_Table::column_default()
Note: See TracTickets for help on using tickets.