A super admin cannot remove themselves from a site

[johnbillion]

A super admin cannot remove themselves from a site, either from the Users listing screen in the site's dashboard or from the Users tab when editing the site. There's no reason to prevent this from being possible.

[birgire]

Here's the restriction in WP_Users_List_Table::single_row() that prevents the current users to delete themselves from the current site:

if ( is_multisite() && get_current_user_id() != $user_object->ID && current_user_can( 'remove_user', $user_object->ID ) )
	$actions['remove'] = "<a class='submitdelete' href='" . wp_nonce_url( $url."action=remove&amp;user=$user_object->ID", 'bulk-users' ) . "'>" . __( 'Remove' ) . "</a>";

​https://github.com/WordPress/WordPress/blob/067970ca827ab970c846b522213a15c9c30ac131/wp-admin/includes/class-wp-users-list-table.php#L416

If I understand correctly we want to allow this removal for the super admin only, maybe with:

if ( is_multisite() && ( get_current_user_id() != $user_object->ID || current_user_can( 'manage_network' ) ) && current_user_can( 'remove_user', $user_object->ID ) )
	$actions['remove'] = "<a class='submitdelete' href='" . wp_nonce_url( $url."action=remove&amp;user=$user_object->ID", 'bulk-users' ) . "'>" . __( 'Remove' ) . "</a>";

or check for the manage_network_users capability instead of manage_network?

I see no removal restrictions, for the current user, in wp-admin/network/site-users.php:

​https://github.com/WordPress/WordPress/blob/067970ca827ab970c846b522213a15c9c30ac131/wp-admin/network/site-users.php#L112-L133

[Mista-Flo]

I have added a simple patch, just removing the condition which said that a current user could not remove itself from a site.

Working well for me

[johnbillion]

In 45407:

Users: Allow Super Admins to remove themselves from a site on a Multisite network.

Props Mista-Flo, birgire

Fixes #41439