Opened 9 years ago
Closed 6 years ago
#41441 closed defect (bug) (fixed)
Deleting a theme from a single site's Themes screen should not be allowed
| Reported by: | johnbillion | Owned by: | johnbillion |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.6 |
| Component: | Themes | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | administration, multisite |
Description
With Multisite enabled, it's not possible to delete a plugin from the Plugins screen in individual sites' dashboards. The Delete link is removed.
The same should be true for themes. Currently, a Delete button is shown when a super admin views the Themes screen on an individual site.
Attachments (2)
Change History (7)
#2
@
7 years ago
- Keywords has-patch added; needs-patch removed
I have added a patch, it's quite simple, just check if we are in multisite or not to display the Delete button.
Also, I do not know if the screenshot is really needed since it would just be two screenshots, one with the button, the other without it.
#3
@
6 years ago
- Keywords needs-screenshots removed
- Milestone Awaiting Review → 5.6
- Owner set to
- Status new → reviewing
#4
@
6 years ago
41441.diff is a slightly different approach, it moves the ! is_multisite() logic to the point where the actions are constructed, therefore keeping the theme deletion logic in one place.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
To me this seems like a good quality of life change and also a good idea to make behaviour between theme and plugin handling of this the same.