Calling a member function on a string object in class-wp-ajax-upgrader-skin.php

[yrpwayne]

In the file:

wp-admin\includes\class-wp-ajax-upgrader-skin.php

on line 102: there is a call to get_error_codes() when the object is a string

public function error( $errors ) {
  if ( is_string( $errors ) ) {
    ...
    $errors_count = count( $errors->get_error_codes() );
    ...
  }
  ...

[yrpwayne]

Looking at the line it should be counting the class variable $errors

Change line 102 to:

$errors_count = count( $this->errors->get_error_codes() );

[SergeyBiryukov]

Hi @yrpwayne, welcome to WordPress Trac!

Thanks for the report, introduced in [38199].

[SergeyBiryukov]

In 41157:

Upgrade/Install: In WP_Ajax_Upgrader_Skin, call ::get_error_codes() method on a WP_Error object $this->errors instead of a string variable $errors.

Props yrpwayne.
Fixes #41449.

[obenland]

#42430 was marked as a duplicate.