WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#41472 closed defect (bug) (fixed)

Travis CI: Use the latest PHPUnit 6.x branch

Reported by: netweb Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:
PR Number:

Description

Follow up to #39822 / [40536] where PHPunit 6.x support was added to use PHPUnit 6.1 for Travis CI PHP 7.x versions

PHPUnit 6.2 was released 2nd June 2017, and the latest 6.2.3 released 3rd July 2017

We should use the latest 6.x branches rather than the 6.1.x branch

Here's a Travis CI job testing this patch as at current SVN revision [41179]

https://travis-ci.org/ntwb/wordpress/builds/258400758 via https://github.com/ntwb/wordpress/pull/4

Attachments (4)

41472.diff (535 bytes) - added by netweb 2 years ago.
41472.patch (604 bytes) - added by ayeshrajans 2 years ago.
A slightly different patch with the caret.
41472.2.patch (725 bytes) - added by ayeshrajans 2 years ago.
Please ignore my previous file. This one is newer and fixes the echo calls as well.
41472.3.diff (782 bytes) - added by netweb 2 years ago.

Download all attachments as: .zip

Change History (20)

@netweb
2 years ago

#1 @netweb
2 years ago

  • Keywords has-patch commit added

#2 @ayeshrajans
2 years ago

I'm sorry if I'm missing something. Can't we composer global require phpunit/phpunit:^6.2?
Composer lately started to recommend the caret operator, and it should pick the latest available release. The patch #1 with asterisk should be functionally the same, but caret is a lot more commonly used in the documentation.

Ref: https://getcomposer.org/doc/articles/versions.md#caret-version-range-

@ayeshrajans
2 years ago

A slightly different patch with the caret.

@ayeshrajans
2 years ago

Please ignore my previous file. This one is newer and fixes the echo calls as well.

@netweb
2 years ago

#3 @netweb
2 years ago

Thanks @ayeshrajans, hadn't seen this until you mentioned it, cheers +1

Refreshed patch uses ^6 and ^4 to use latest PHPUnit 6.x and 4.x respectively where required

https://semver.mwl.be/#?package=phpunit%2Fphpunit&version=%5E6&minimum-stability=stable
https://semver.mwl.be/#?package=phpunit%2Fphpunit&version=%5E4&minimum-stability=stable

#4 @johnbillion
2 years ago

  • Owner set to johnbillion
  • Status changed from new to reviewing

I'm confident in PHPUnit's ability to follow semver without breaking compatibility within a major version, so let's do this.

#5 @johnbillion
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41294:

Build/Test tools: Use the latest in the 4.x and 6.x branches of PHPUnit when running tests on Travis.

Props netweb, ayeshrajans

Fixes #41472

#6 @johnbillion
2 years ago

  • Keywords fixed-major added; has-patch commit removed
  • Resolution fixed deleted
  • Status changed from closed to reopened

This should be back-ported to branches. Doesn't need a patch, I'll merge.

#7 @johnbillion
2 years ago

In 41295:

Build/Test tools: Use the latest in the 4.x and 6.x branches of PHPUnit when running tests on Travis for the 4.8 branch.

See #41472

Merges [41294] to the 4.8 branch.

#8 @johnbillion
2 years ago

In 41296:

Build/Test tools: Use the latest in the 4.x and 6.x branches of PHPUnit when running tests on Travis for the 4.7 branch.

See #41472

Merges [41294] to the 4.7 branch.

#9 @johnbillion
2 years ago

In 41297:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.6 branch.

See #41472

#10 @johnbillion
2 years ago

In 41298:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.5 branch.

See #41472

#11 @johnbillion
2 years ago

In 41299:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.4 branch.

See #41472

#12 @johnbillion
2 years ago

In 41300:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.3 branch.

See #41472

#13 @johnbillion
2 years ago

In 41301:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.2 branch.

See #41472

#14 @johnbillion
2 years ago

In 41302:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.1 branch.

See #41472

#15 @johnbillion
2 years ago

In 41303:

Build/Test tools: Use the latest in the 4.x and 5.x branches of PHPUnit when running tests on Travis for the 4.0 branch.

See #41472

#16 @johnbillion
2 years ago

  • Keywords fixed-major removed
  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.