Opened 7 years ago
Closed 7 years ago
#41499 closed defect (bug) (fixed)
Menu name and action button too close in responsive below 500px.
Reported by: | punit5658 | Owned by: | afercia |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Menus | Keywords: | has-patch has-screenshots |
Focuses: | ui, administration | Cc: |
Description
Menu name input and save menu too close below 500px. Added media styles for improve mobile accessibility to End user.
Attachments (6)
Change History (14)
#3
follow-up:
↓ 4
@
7 years ago
- Focuses accessibility removed
Removing accessibility focus, as this is not an accessibility issue.
#4
in reply to:
↑ 3
@
7 years ago
Replying to joedolson:
Removing accessibility focus, as this is not an accessibility issue.
Thanks @joedolson for looking ticket and update focuses.
#5
@
7 years ago
- Keywords has-screenshots needs-refresh added
- Milestone changed from Awaiting Review to 4.9
- Owner set to afercia
- Status changed from new to assigned
- Version trunk deleted
@punit5658 thanks and welcome to Trac.
Seems something worth fixing! However, a fixed value of 86px
in width: calc( 100% - 86px );
doesn't take into account the label could be longer (or shorter) when translated in other languages. Just an example:
A more solid solution would probably be making the elements stacked vertically under a certain viewport width. There's no need for the label and the input field to be always on the same line also on small screens.
Also, you may want to have a look at the WordPress CSS coding standards about spaces, etc. Indentation should always use tab characters and not spaces, and every file should end with an empty line.
#7
@
7 years ago
- Keywords needs-refresh removed
Looks good to me. 41499.2.diff just uses the new rules when the responsive view kicks in and saves a media query. Also removes an unused rule and fixes one indentation (was using spaces instead of tabs).
Patch for Menu name and save button UI improvement.