Make WordPress Core

Context Navigation

← Previous Ticket
Next Ticket →

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#41505 closed enhancement (fixed)

Pass $decimals argument to number_format_i18n filter

Reported by:	alpipego	Owned by:	johnbillion
Priority:	normal	Milestone:	4.9
Component:	Formatting	Version:
Severity:	normal	Keywords:	has-patch
Cc:		Focuses:

Description

Filtering the value passed from number_format_l18n is limited as one can only guess the value for $decimals.

$decimals should be passed to the filter, to make it more useful.

Attachments (1)

number_format_l18n.41505.diff (555 bytes ) - added by alpipego 9 years ago.

Download all attachments as: .zip

Change History (7)

@alpipego
9 years ago

Attachment number_format_l18n.41505.diff added

#1 @alpipego
9 years ago

Keywords has-patch added

#2 @johnbillion
9 years ago

Milestone Awaiting Review → 4.9
Owner set to johnbillion
Status new → reviewing

#3 @johnbillion
9 years ago

Summary Pass $decimals argument to number_format_l18n filter → Pass $decimals argument to number_format_i18n filter

#4 @johnbillion
9 years ago

Resolution → fixed
Status reviewing → closed

Formatting: Add the $number and $decimals arguments to the number_format_i18n filter.

Props alpipego

Fixes #41505

#5 follow-up: ↓ 6 @johnbillion
9 years ago

@alpipego Thanks for the patch. I added the raw $number parameter too, as the formatted number on its own isn't very useful if you're re-formatting the number.

#6 in reply to: ↑ 5 @alpipego
9 years ago

I added the raw $number parameter too, as the formatted number on its own isn't very useful if you're re-formatting the number.

Ah that's great, didn't think about that. Thanks!

Version 0, edited 9 years ago by alpipego (next)

Note: See TracTickets for help on using tickets.

Download in other formats: