WordPress.org

Make WordPress Core

Opened 4 months ago

Last modified 6 weeks ago

#41514 new defect (bug)

Registration links disappear after requesting a password reset link

Reported by: henry.wright Owned by:
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch needs-testing early
Focuses: Cc:

Description

After requesting a password reset link at example.com/wp-login.php?action=lostpassword, the registration links (that were under the Log In button) disappear. See the attached screenshot(s) for visuals.

Attachments (7)

Screenshot 2017-08-01 at 16.13.48.png (17.1 KB) - added by henry.wright 4 months ago.
Before
Screenshot 2017-08-01 at 16.14.09.png (15.4 KB) - added by henry.wright 4 months ago.
After
41514.diff (1.1 KB) - added by birgire 4 months ago.
The register link displayed for checkemail=newpass and checkemail=confirm
register-link-on-confirm.JPG (23.9 KB) - added by birgire 4 months ago.
Screenshot of the register link on /wp-login.php?checkemail=confirm
Screenshot 2017-08-03 at 16.36.14.png (14.6 KB) - added by henry.wright 4 months ago.
@birgire is it worth also adding a "Lost your password?" link? Attached is a screenshot of the standard login page. Note there are 2 links
41514.2.patch (1.1 KB) - added by birgire 7 weeks ago.
41514.3.diff (1.1 KB) - added by birgire 7 weeks ago.
Refreshed the patch with respect to #40802

Download all attachments as: .zip

Change History (13)

@birgire
4 months ago

The register link displayed for checkemail=newpass and checkemail=confirm

#1 @birgire
4 months ago

  • Keywords has-patch added

@birgire
4 months ago

Screenshot of the register link on /wp-login.php?checkemail=confirm

#2 @johnbillion
4 months ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 4.9

@henry.wright
4 months ago

@birgire is it worth also adding a "Lost your password?" link? Attached is a screenshot of the standard login page. Note there are 2 links

@birgire
7 weeks ago

#3 @birgire
7 weeks ago

@henry.wright it looks like I missed your ping.

I updated the patch with 41514.2.patch to show "Lost your password?" link too.

Maybe you can test it?

Last edited 7 weeks ago by birgire (previous) (diff)

#4 in reply to: ↑ description @SergeyBiryukov
7 weeks ago

  • Keywords reporter-feedback added

Replying to henry.wright:

After requesting a password reset link at example.com/wp-login.php?action=lostpassword, the registration links (that were under the Log In button) disappear.

I'm not sure I see an issue with that. Having just requested a password reset link, why would you need to go back to registration or password reset form?

#5 @henry.wright
7 weeks ago

@birgire 41514.2.patch looks good but see #40802 which allows the hard coded pipe character to be filtered with the new login_link_separator hook.

@SergeyBiryukov I agree the user is likely to not use the link but I think the link should be there to keep a consistent look and feel with the rest of the wp-login.php screens.

@birgire
7 weeks ago

Refreshed the patch with respect to #40802

#6 @SergeyBiryukov
6 weeks ago

  • Keywords early added; reporter-feedback removed
  • Milestone changed from 4.9 to Future Release

#40605 suggests removing the login form from the "Check your email for the confirmation link" screen altogether. Let's figure out the best way forward in early 5.0.

Note: See TracTickets for help on using tickets.