WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 15 months ago

Last modified 15 months ago

#41514 closed defect (bug) (fixed)

Registration links disappear after requesting a password reset link

Reported by: henry.wright Owned by: SergeyBiryukov
Milestone: 5.5 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: has-patch needs-testing early
Focuses: Cc:

Description

After requesting a password reset link at example.com/wp-login.php?action=lostpassword, the registration links (that were under the Log In button) disappear. See the attached screenshot(s) for visuals.

Attachments (7)

Screenshot 2017-08-01 at 16.13.48.png (17.1 KB) - added by henry.wright 4 years ago.
Before
Screenshot 2017-08-01 at 16.14.09.png (15.4 KB) - added by henry.wright 4 years ago.
After
41514.diff (1.1 KB) - added by birgire 4 years ago.
The register link displayed for checkemail=newpass and checkemail=confirm
register-link-on-confirm.JPG (23.9 KB) - added by birgire 4 years ago.
Screenshot of the register link on /wp-login.php?checkemail=confirm
Screenshot 2017-08-03 at 16.36.14.png (14.6 KB) - added by henry.wright 4 years ago.
@birgire is it worth also adding a "Lost your password?" link? Attached is a screenshot of the standard login page. Note there are 2 links
41514.2.patch (1.1 KB) - added by birgire 4 years ago.
41514.3.diff (1.1 KB) - added by birgire 4 years ago.
Refreshed the patch with respect to #40802

Download all attachments as: .zip

Change History (16)

@birgire
4 years ago

The register link displayed for checkemail=newpass and checkemail=confirm

#1 @birgire
4 years ago

  • Keywords has-patch added

@birgire
4 years ago

Screenshot of the register link on /wp-login.php?checkemail=confirm

#2 @johnbillion
4 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 4.9

@henry.wright
4 years ago

@birgire is it worth also adding a "Lost your password?" link? Attached is a screenshot of the standard login page. Note there are 2 links

@birgire
4 years ago

#3 @birgire
4 years ago

@henry.wright it looks like I missed your ping.

I updated the patch with 41514.2.patch to show "Lost your password?" link too.

Maybe you can test it?

Last edited 4 years ago by birgire (previous) (diff)

#4 in reply to: ↑ description @SergeyBiryukov
4 years ago

  • Keywords reporter-feedback added

Replying to henry.wright:

After requesting a password reset link at example.com/wp-login.php?action=lostpassword, the registration links (that were under the Log In button) disappear.

I'm not sure I see an issue with that. Having just requested a password reset link, why would you need to go back to registration or password reset form?

#5 @henry.wright
4 years ago

@birgire 41514.2.patch looks good but see #40802 which allows the hard coded pipe character to be filtered with the new login_link_separator hook.

@SergeyBiryukov I agree the user is likely to not use the link but I think the link should be there to keep a consistent look and feel with the rest of the wp-login.php screens.

@birgire
4 years ago

Refreshed the patch with respect to #40802

#6 @SergeyBiryukov
4 years ago

  • Keywords early added; reporter-feedback removed
  • Milestone changed from 4.9 to Future Release

#40605 suggests removing the login form from the "Check your email for the confirmation link" screen altogether. Let's figure out the best way forward in early 5.0.

#7 @SergeyBiryukov
15 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 48304:

Login and Registration: Hide the login form on the "check your email" step of new user registration or password reset.

This aims to reduce some confusion and make it clearer that the email should be checked before attempting to log in right away.

Props rianrietveld, pratik028, bdbch, johnbillion, hankthetank, yashrs, williampatton, audrasjb, bmartinent, florianatwhodunit, henry.wright, birgire, SergeyBiryukov.
Fixes #40605, #41514.

#8 @SergeyBiryukov
15 months ago

  • Milestone changed from Future Release to 5.5

#9 @SergeyBiryukov
15 months ago

In 48305:

Login and Registration: Set a more appropriate page title for the "check your email" step of new user registration or password reset.

Follow-up to [48304].

See #40605, #41514.

Note: See TracTickets for help on using tickets.