edit_post_link return/echo

[christianskarby]

I suggest the following API-change to allow for templates to decide whether the text should be displayed from within the edit_post_link function (legacy) or returned back as a string.

from: edit_post_link($link = 'Edit This', $before = '', $after = '')
to:   edit_post_link($link = 'Edit This', $before = '', $after = '', $echo=true)

[ryan]

We can add get_edit_post_link() that returns the bare link. Output should be run through a 'edit_post_link' filter. edit_post_link() would then call get_edit_post_link(). Same can be done for edit_comment_link(). See all of the other get_*_link() functions.

[rob1n]

Yeah, having get_edit_post_link() makes sense.

[rob1n]

(In [5275]) Add get_edit_comment_link() and get_edit_post_link(). fixes #4153

[kkwangen]

There was as missing " on line 296 in link-template.php causes the entire page/ post to becoming an edit this link. I've attached the fixed one I made.

[dpryo]

Seriously.

Where's the QA team? :)

I attached a patch. You probably understand.

[westi]

/me slaps rob1n - test test test commit ;-)

[foolswisdom]

dpryo, no I don't understand, though attaching as a patch is appreciated.
I think this has already been corrected, [5276] (and then also [5277]).

[foolswisdom]

Nvr mind me.

[mdawaffe]

4153.diff

1. dpryo's quote mark (keeps link from being displayed in browser).
2. Get rid of unused variable.

[rob1n]

I'll tackle this when I get home.

[ryan]

get_edit_post_link() shouldn't return an anchor with href, just the link itself as do the other get functions. The link should be passed through a filter for those who want to change the link.

[ryan]

(In [5282]) Revert [5275] - [5277]. Fix it later. see #4153

[rob1n]

Okay, this time around:

1. TEST TEST TEST (/me slaps self)

2. get_edit_*_link() returns URL, not code

3. Filters, filters, filters.

Working on a patch.

[ryan]

WP coding style doesn't put braces around one line if statements. Other than that, looks good.

[rob1n]

(In [5302]) get_edit_*_link() functions. fixes #4153