WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 22 months ago

#41557 closed defect (bug) (fixed)

Customize edit shortcuts mispositioned when nested inside Twenty Seventeen frontpage panel

Reported by: westonruter Owned by: davidakennedy
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: Cc:

Description

When using a plugin like Customize Posts which adds nested partials inside of the front page panels, the edit shortcuts for these nested partials are mispositioned in Twenty Seventeen due to this CSS selector:

/* Add some space around the visual edit shortcut buttons. */
.twentyseventeen-panel .customize-partial-edit-shortcut button {
        top: 30px;
        left: 30px;
}

It should instead be using direct descendent selectors like so:

/* Add some space around the visual edit shortcut buttons. */
.twentyseventeen-panel > .customize-partial-edit-shortcut > button {
        top: 30px;
        left: 30px;
}

Attachments (3)

41557.0.diff (512 bytes) - added by westonruter 2 years ago.
panel-nested-shortcut-mispositioned.png (265.7 KB) - added by westonruter 2 years ago.
Before
panel-nested-shortcut-fixed.png (277.2 KB) - added by westonruter 2 years ago.
After

Download all attachments as: .zip

Change History (6)

@westonruter
2 years ago

#1 @westonruter
2 years ago

  • Keywords has-patch added
  • Owner set to davidakennedy
  • Status changed from new to reviewing

#2 @westonruter
2 years ago

PR to workaround the issue in Customize Posts: https://github.com/xwp/wp-customize-posts/pull/357

#3 @westonruter
22 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41842:

Twenty Seventeen: Fix positioning of edit shortcuts when partials are nested inside a frontpage panel.

Fixes #41557.

Note: See TracTickets for help on using tickets.