WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 3 weeks ago

#41566 closed defect (bug) (fixed)

Function Description : /wp-signup.php

Reported by: mt8.biz Owned by: SergeyBiryukov
Milestone: 5.9 Priority: normal
Severity: normal Version: 3.0
Component: Login and Registration Keywords: has-patch
Focuses: docs Cc:

Description

There is no descrption for global vars

Attachments (6)

wp-signup.php.diff (1.0 KB) - added by mt8.biz 4 years ago.
wp-signup.php-indent-fix.diff (1.0 KB) - added by mt8.biz 4 years ago.
fix indent
wp-signup.php-refix.diff (1.0 KB) - added by mt8.biz 4 years ago.
wp-signup.php.2.diff (1.0 KB) - added by mt8.biz 4 years ago.
some fix. thanks @westonruter
41566.diff (1.2 KB) - added by sabernhardt 2 months ago.
41566.1.diff (2.4 KB) - added by audrasjb 3 weeks ago.
Refreshes the last patch and use third-person for few occurrences of the verb "Validate" for better consistency

Download all attachments as: .zip

Change History (11)

#1 @johnbillion
4 years ago

  • Component changed from General to Login and Registration
  • Focuses docs added
  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 4.9

@mt8.biz
4 years ago

fix indent

#2 @westonruter
4 years ago

  • Milestone changed from 4.9 to Future Release

There is no $wpdb used in the validate_another_blog_signup() function. The global defined in signup_user() is lacking a complete sentence.

@mt8.biz
4 years ago

some fix. thanks @westonruter

#3 @mukesh27
3 years ago

#46273 was marked as a duplicate.

@sabernhardt
2 months ago

#4 @sabernhardt
2 months ago

  • Milestone changed from Future Release to 5.9

The globals have been listed for validate_another_blog_signup since r43326, but I moved the since line before those.

This patch also includes the $active_signup global for signup_user (as the previous patch had).

@audrasjb
3 weeks ago

Refreshes the last patch and use third-person for few occurrences of the verb "Validate" for better consistency

#5 @SergeyBiryukov
3 weeks ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 51699:

Docs: Improve documentation in wp-signup.php.

  • Document the $active_signup global in signup_user().
  • Update some DocBlocks per the documentation standards.
  • Expand some function descriptions for clarity.

Follow-up to [37535], [37536], [41200], [43326], [49078], [50828].

Props mt8.biz, sabernhardt, audrasjb, westonruter, jayupadhyay01, mukesh27, SergeyBiryukov.
Fixes #41566.

Note: See TracTickets for help on using tickets.