WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 18 months ago

#41577 new defect (bug)

Fix Notice fixing

Reported by: glehner Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 4.8.1
Component: Canonical Keywords:
Focuses: Cc:
PR Number:

Description

The file wp-includes/canonical.php produces Notices for undefined indexes when a requested uri has no path or query.

The attached patch sets the indexes to empty strings.

#6977 (which was not used) had a different approach. The currently used "Notice fixing" approach does not fix up $original which is used afterwards.

Attachments (1)

canonical.php.patch (944 bytes) - added by glehner 2 years ago.

Download all attachments as: .zip

Change History (3)

#2 in reply to: ↑ description @Andy Schmidt
18 months ago

  • Type changed from enhancement to defect (bug)

Replying to glehner:
FYI: The same problem exists with $originalhost? not being tested for 'undefined' in the code line right above your own patch, see https://core.trac.wordpress.org/ticket/34353#comment:10.

Note: See TracTickets for help on using tickets.