WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#41584 closed defect (bug) (fixed)

Upgrade Twemoji to 2.5.0

Reported by: pento's profile pento Owned by: pento's profile pento
Milestone: 4.8.2 Priority: normal
Severity: normal Version: 4.8
Component: Emoji Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Twemoji 2.3.0 (currently in Core) has a ​rendering issue in Safari, emoji can sometimes be followed by U+FEOF (which is just a flag meaning "render the preceding character as emoji).

Twemoji wasn't catching this character correctly, and Safari rendered it incorrectly.

See this codepen for an example: ​https://codepen.io/fvcproductions/pen/qXrmbq

Attachments (1)

41584.diff​ (4.2 KB) - added by peterwilsoncc 6 years ago.

Download all attachments as: .zip

Change History (7)

#1 @peterwilsoncc
6 years ago

  • Owner set to peterwilsoncc
  • Status changed from new to accepted

@pento, I'll update this in trunk Monday AEST & reassign for back-porting. No changes to the CDN are required.

@peterwilsoncc
6 years ago

#2 @peterwilsoncc
6 years ago

  • Keywords has-patch commit added

#3 @peterwilsoncc
6 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41250:

Emoji: Update Twemoji to 2.5.0.

Twemoji 2.3.0 has a rendering issue in Safari, emoji can sometimes be followed by U+FEOF (which is just a flag meaning "render the preceding character as emoji).

Twemoji wasn't catching this character correctly, and Safari rendered it incorrectly.

Twemoji 2.5.0 resolves this issue.

Fixes #41584.

#4 @peterwilsoncc
6 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backporting.

#5 @peterwilsoncc
6 years ago

  • Owner changed from peterwilsoncc to pento
  • Status changed from reopened to assigned

#6 @ocean90
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41394:

Emoji: Update Twemoji to 2.5.0.

  • Twemoji 2.3.0 has a rendering issue in Safari, emoji can sometimes be followed by U+FEOF (which is just a flag meaning "render the preceding character as emoji).
  • Twemoji wasn't catching this character correctly, and Safari rendered it incorrectly.
  • Twemoji 2.5.0 resolves this issue.

Merge of [41250] to the 4.8 branch.

Props peterwilsoncc.
Fixes #41584.

Note: See TracTickets for help on using tickets.