Widgets: Default to "custom URL" in the image widget

[melchoyce]

To help improve discoverability of custom URLs in the image widget, let's default to showing them rather than Link to: none.

See before/after screenshots.

[joemcgill]

@melchoyce do we only want this as the default in the image widget, or across all instances of the media modal, i.e., in the post edit screen as well?

[joemcgill]

No sooner did I ask that question than did @desrosj come across #31467 (Images should default to not linking).

[melchoyce]

Replying to joemcgill:

@melchoyce do we only want this as the default in the image widget, or across all instances of the media modal, i.e., in the post edit screen as well?

Only the image widget.

[philmcdonnell]

What would be the case if the user didn't enter anything and just submitted the form? The ​http:// that is there is just a placeholder so it would not save I assume?

[joemcgill]

Replying to philmcdonnell:

What would be the case if the user didn't enter anything and just submitted the form? The ​http:// that is there is just a placeholder so it would not save I assume?

The behavior should work just like it currently does if the form is submitted while custom URL is selected and the URL field is left blank. The image is inserted with no link at all.

[philmcdonnell]

Replying to joemcgill:

The behavior should work just like it currently does if the form is submitted while custom URL is selected and the URL field is left blank. The image is inserted with no link at all.

Thanks! That is what I thought, just making sure. So it is trivial to make this work, however there are two links withing the image widget, one is replace image which uses the same code as the original insert image so that would work as expected. There is another link (button) that says edit image, what would the expected behavior be there? If there is no link currently on the inserted image it would just default to 'none' or would that want to default to custom url as well? I would think editing an existing should be set to none if that is what was there originally. Thoughts?

[joemcgill]

Replying to philmcdonnell:

If there is no link currently on the inserted image it would just default to 'none' or would that want to default to custom url as well? I would think editing an existing should be set to none if that is what was there originally. Thoughts?

I think your suggestion makes sense. Additionally, if a site has the image_default_link_type option set, we should probably respect it. So this would only apply as a default when that option is not set.

[joemcgill]

Also, I'm assigning to @desrosj for further review, but @philmcdonnell feel free to add a patch if you have an approach you think will work. Thanks!

[westonruter]

Bumping priority to high for visibility and alignment with 4.9 goals, and given proximity to beta 1 deadline.

[bor0]

The proposed patch defaults to Link To: Custom URL: http://. If no URL changes are done, on every subsequent edit it will show as Link To: None.

However, if we add http://www.wordpress.org initially as the Custom URL, then it will show as Link To: Custom URL: http://www.wordpress.org, which is as expected.

[desrosj]

I tested @bor0's patch. This tackles the situation when editing widgets in the admin, but not in the Customizer

41629.2.patch​ is an extension of that change that also changes the behavior through the Customizer.

Previously, the default image_default_link_type option was not being respected when selecting an image for an image widget in the Customizer. 41629.2.patch​ now respects the default option, but introduces a new option specifically for the image widget, image_default_widget_link_type. This will be custom when not present in the database.

[desrosj]

Remove addition of new option and hardcode custom as the default for widgets instead.

[desrosj]

As discussed in the component's weekly meeting, 41629.diff​ removes the addition of a new option in favor of hardcoding custom as the default for image widgets.

[desrosj]

@joemcgill tested the original patch and said that it was working for him. I gave 41629.patch​ another go and it worked correctly for me as well. Not sure why I did not see the correct behavior when testing initially but can confirm that 41629.patch​ works for me now.

[joemcgill]

In 41696:

Widgets: Default to "custom URL" in the image widget.

This changes the default value for link_type in the image widget
schema to 'custom'.

Props bor0, desrosj.
Fixes #41629.