WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

Last modified 9 years ago

#41630 closed enhancement (fixed)

Widgets: Add a background behind image widget images if they aren't full width

Reported by: melchoyce Owned by: melchoyce
Priority: normal Milestone: 4.9
Component: Widgets Version:
Severity: normal Keywords: good-first-bug has-patch commit
Cc: Focuses: ui

Description

See attached images. Background color is #eee.

Attachments (5)

before.png​ (57.0 KB ) - added by melchoyce 9 years ago.
after.png​ (56.7 KB ) - added by melchoyce 9 years ago.
after-square.jpg​ (39.4 KB ) - added by m1tk00 9 years ago.
Something like this? Ill be happy to do it
41630.diff​ (384 bytes ) - added by mrasharirfan 9 years ago.
Added background color ​https://i.imgur.com/aE30dpS.png
41630.2.diff​ (572 bytes ) - added by mrasharirfan 9 years ago.
Improved image spacing in the container.

Download all attachments as: .zip

Change History (14)

@melchoyce
9 years ago

@melchoyce
9 years ago

#1 @westonruter
9 years ago

  • Keywords good-first-bug added

#2 @alexvorn2
9 years ago

maybe add a squared repetitive background like in photoshop, with grey and white squares

@m1tk00
9 years ago

Something like this? Ill be happy to do it

@mrasharirfan
9 years ago

Added background color ​https://i.imgur.com/aE30dpS.png

#3 @mrasharirfan
9 years ago

  • Keywords has-patch added

@mrasharirfan
9 years ago

Improved image spacing in the container.

#5 @melchoyce
9 years ago

  • Keywords commit added

Using the transparency pattern is a good idea, but I think in practice it might be a little too distracting. 41630.2.diff​ looks good to commit to me 👍 Thanks for working on this, @mrasharirfan :)

#6 @mrasharirfan
9 years ago

You are welcome @melchoyce 😊
It is my first time contributing to WordPress Core 😇

#7 @melchoyce
9 years ago

  • Owner set to melchoyce
  • Resolution → fixed
  • Status new → closed

In 41309:

Widgets: Add grey background behind image widgets.

When an image in the image widget isn't full-width, it looks like it's floating. This adds a grey background behind images to help ground them in the widget.

Props mrasharirfan.
Fixes #41630.

#8 @melchoyce
9 years ago

Congrats @mrasharirfan! 🎉 Thanks for your patch :)

This ticket was mentioned in ​Slack in #core by mrasharirfan. ​View the logs.
9 years ago

Note: See TracTickets for help on using tickets.