![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
#41645 closed defect (bug) (fixed)
i18n: Avoid using HTML tags in translation strings (wp-activate.php)
| Reported by: | ramiy | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 4.9 |
| Component: | I18N | Version: | |
| Severity: | normal | Keywords: | has-patch |
| Cc: | Focuses: | multisite |
Description
The old translation string:
Your site at <a href="%1$s">%2$s</a> is active. You may now log in to your site using your chosen username of “%3$s”. Please check your email inbox at %4$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can <a href="%5$s">reset your password</a>.
Is using <a href="%1$s">%2$s</a>. This can be replaced with a simple %1$s moving the HTML tags out of the string. Making is much easier for translation, Especially in RTL languages like Hebrew where bi-directional languages are difficult to handle.
Attachments (2)
Change History (11)
#2
@
9 years ago
- Component Text Changes → I18N
- Focuses multisite added
- Milestone Awaiting Review → 4.9
- Owner set to
- Status new → reviewing
#3
@
9 years ago
- Summary Simplify translation string (in wp-activate.php file) → i18n: Avoid using HTML tags in translation strings (wp-activate.php)
This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.
9 years ago
Note:
See TracTickets
for help on using tickets.
Old string:
Your site at <a href="%1$s">%2$s</a> is active. You may now log in to your site using your chosen username of “%3$s”. Please check your email inbox at %4$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can <a href="%5$s">reset your password</a>.New string:
'Your site at %1$s is active. You may now log in to your site using your chosen username of “%2$s”. Please check your email inbox at %3$s for your password and login instructions. If you do not receive an email, please check your junk or spam folder. If you still do not receive an email within an hour, you can <a href="%4$s">reset your password</a>.