WordPress.org

Make WordPress Core

Opened 2 years ago

Last modified 8 months ago

#41648 new defect (bug)

Alignment issue on media-new.php when browse uploader screen is active

Reported by: krupajnanda Owned by:
Milestone: Future Release Priority: low
Severity: minor Version: 4.8.1
Component: Media Keywords: good-first-bug has-patch
Focuses: ui, administration Cc:
PR Number:

Description

While adding any media from browse upload screen, the message it shows when the file is uploaded or not, that isn't aligned properly with the button.

Steps:

  1. Goto /wp-admin/media-new.php page.
  2. Switch to browse uploader
  3. Check here

Please check attachment 1 and 2 for the same.

Attachments (4)

browser uploader - When file is not attached.png (25.2 KB) - added by krupajnanda 2 years ago.
browser uploader - When file is attached.png (25.3 KB) - added by krupajnanda 2 years ago.
expectd output.png (3.3 KB) - added by krupajnanda 2 years ago.
It should look something like as shown in expected output.png file
41648.diff (411 bytes) - added by andraganescu 8 months ago.
CSS fixing the text alignment for the upload input

Download all attachments as: .zip

Change History (11)

@krupajnanda
2 years ago

It should look something like as shown in expected output.png file

This ticket was mentioned in Slack in #core-media by mike. View the logs.


9 months ago

#2 @mikeschroder
9 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release
  • Priority changed from normal to low
  • Severity changed from normal to minor

Thanks so much for the report, and sorry it's taken so long for a response.

Because this is an older upload method, I'm lowering the priority on the ticket, but would be happy to merge/commit a fix if it's available.

Related: #41024

#3 @aaroncampbell
9 months ago

I'm not much of a CSS expert, so I'm sure what the real fix is here. But when playing with this as part of a bug scrub today I did notice that getting rid of the font-size:14px that’s applied to input, select, textarea in wp-admin/css/forms.css seems to line it up right (shrinking the font to 13px in the process for me?).

It’s like the font in the input it affected by that but not the font in the button, but I don't know what other areas of wp-admin this would affect.

#4 follow-up: @lucagrandicelli
8 months ago

Hi @krupajnanda, used browser?

#5 in reply to: ↑ 4 @krupajnanda
8 months ago

Replying to lucagrandicelli:

Hi @krupajnanda, used browser?

This was checked on Chrome, Firefox and Safari browsers for MAC OS

@andraganescu
8 months ago

CSS fixing the text alignment for the upload input

#6 follow-up: @andraganescu
8 months ago

  • Keywords has-patch added; needs-patch removed

I've added a small patch that should fix the misalignment here

https://core.trac.wordpress.org/attachment/ticket/41648/41648.diff

#7 in reply to: ↑ 6 @krupajnanda
8 months ago

Replying to andraganescu:

I've added a small patch that should fix the misalignment here

https://core.trac.wordpress.org/attachment/ticket/41648/41648.diff

Thank you

Note: See TracTickets for help on using tickets.