Info regex is too greedy

[kapoylski]

In the WordPress admin, under Write > Write Page there is a drop-down box for selecting the page template. When I create my own page templates and add them, the box lists them, but includes extra characters alongside the name. If I alter the regular expression used in get_page_templates() in the admin_functions.php on line 1247 file from:

preg_match( "|Template Name:(.*)|i", $template_data, $name );

to:

preg_match( "|Template Name:([^\*]*)|i", $template_data, $name );

It no longer includes the characters. I assume the preg_match statement is just matching too much and returning it as the template name. I'm attaching the two template files that exhibit this problem, as well as a screen-shot of what I'm seeing.

[Otto42]

Would this line work instead?

preg_match( "|Template Name:(.*)$|i", $template_data, $name );

Your line excludes asterisks from the match, whereas mine explicitly specifies the end of line outside the matching string. I don't know why yours continues to match beyond the end of the line, but this might work as well and still allow * characters in the Template Name.

[rob1n]

The PREG "m" modifier treats the multi-line string's lines as each a string (​see here). Thus, the $ would match the end of the line.

[rob1n]

might as well do them all

[rob1n]

New patch does theme, template and plugin get info functions

[rob1n]

(In [5630]) Keep greedy regex's in control. fixes #4165