Make WordPress Core

Opened 6 years ago

Closed 6 years ago

Last modified 6 years ago

#41652 closed defect (bug) (fixed)

i18n: Use %s placeholders in network translation string

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: administration, multisite Cc:


In the network translation string

The constant DO_NOT_UPGRADE_GLOBAL_TABLES cannot be defined when creating a network.

the constant name can be mistakenly changes by the translator.

The best practice is to replace the DO_NOT_UPGRADE_GLOBAL_TABLES constant with a %s placeholder.

The patch also adds <code> tag around the constant name.

Attachments (1)

41652.patch (781 bytes) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (6)

6 years ago

#1 @SergeyBiryukov
6 years ago

  • Focuses multisite added
  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @johnbillion
6 years ago

  • Keywords has-patch added

This ticket was mentioned in Slack in #core-multisite by jeremyfelt. View the logs.

6 years ago

#4 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41923:

I18N: Remove hardcoded constant from a translatable string in network_step1().

Props ramiy.
Fixes #41652.

#5 @SergeyBiryukov
6 years ago

In 41924:

Network Admin: After [41923], move the second <p> tag to a new line for better readability.

See #41652.

Note: See TracTickets for help on using tickets.