Enable dead_db() to be trappable always.

[gitlost]

It would be handy if dead_db() could be made trappable always, either through using wp_die() instead of die() in the terse case, or via a filter.

It currently causes WP-CLI (see ​https://github.com/wp-cli/wp-cli/pull/4303) to resort to a brittle hack in order to trap database connection errors.

[gitlost]

Terse die() at 360 width Firefox.

[gitlost]

Terse wp_die() at 360 width Firefox.

[gitlost]

Terse die() at 1280 width Firefox.

[gitlost]

Terse wp_die() at 1280 width Firefox.

[gitlost]

The above are before/afters if die() were replaced by wp_die() in the terse case, eg

wp_die( '<h1>' . __( 'Error establishing a database connection' ) . '</h1>', __( 'Database Error' ) );

[gitlost]

Patch to use wp_die() instead of die() in the terse case in dead_db().

[spacedmonkey]

Related: #45974 #45975

[spacedmonkey]

Marking as 5.2. See arguments for this ticket here

[SergeyBiryukov]

Introduced in [6447] for #5500.

[SergeyBiryukov]

In 44827:

Database: Use wp_die() instead of die() in dead_db(), for more flexibility and consistency with other error messages in core.

Props gitlost.
Fixes #41655.

[desrosj]

As far as I can tell, this one never received a dev note. Going to remove needs-dev-note as the ship has already sailed.