WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 4 weeks ago

#41667 reviewing defect (bug)

i18n: Use %s placeholders in rest api translation strings

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: rest-api Cc:

Description

This patch has several changes:

  1. It replaces the register_routes() method with a %s placeholder.
  2. It replaces the apostrophe around the %s placeholders with <code> tags.
  3. It adds translators comments to all the translation strings.

Attachments (2)

41667.png (37.4 KB) - added by ramiy 5 weeks ago.
41667.patch (7.4 KB) - added by ramiy 5 weeks ago.

Download all attachments as: .zip

Change History (7)

@ramiy
5 weeks ago

@ramiy
5 weeks ago

#1 @ramiy
5 weeks ago

The patch also adds a period at the end of the sentence and it has a small text change to match the other string.

Old translation strings:

  • The register_routes() method must be overridden
  • Method '%s' not implemented. Must be overridden in subclass.

New translation strings:

  • Method %s must be overridden.
  • Method %s not implemented. Must be overridden in subclass.

#3 @Soean
5 weeks ago

  • Keywords has-patch added

#4 @SergeyBiryukov
4 weeks ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#5 @ramiy
4 weeks ago

Clarification about the text changes - this patch replace 12 strings:

  • Method '%s' not implemented. Must be overridden in subclass.

With:

  • Method %s not implemented. Must be overridden in subclass.

And also, it replaces one string:

  • The register_routes() method must be overridden

With:

  • Method %s must be overridden.
Note: See TracTickets for help on using tickets.