Opened 7 years ago
Closed 7 years ago
#41667 closed defect (bug) (fixed)
i18n: Use %s placeholders in rest api translation strings
Reported by: | ramiy | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | |
Component: | I18N | Keywords: | has-patch |
Focuses: | rest-api | Cc: |
Description
This patch has several changes:
- It replaces the
register_routes()
method with a%s
placeholder. - It replaces the apostrophe around the
%s
placeholders with<code>
tags. - It adds translators comments to all the translation strings.
Attachments (2)
Change History (12)
#4
@
7 years ago
- Milestone changed from Awaiting Review to 4.9
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#5
@
7 years ago
Clarification about the text changes - this patch replace 12 strings:
Method '%s' not implemented. Must be overridden in subclass.
With:
Method %s not implemented. Must be overridden in subclass.
And also, it replaces one string:
The register_routes() method must be overridden
With:
Method %s must be overridden.
#6
@
7 years ago
I'd suggest only changing the register_routes()
string and leaving the Method '%s' not implemented
strings as is, I'm not sure HTML is allowed in all contexts there.
Note: See
TracTickets for help on using
tickets.
The patch also adds a period at the end of the sentence and it has a small text change to match the other string.
Old translation strings:
The register_routes() method must be overridden
Method '%s' not implemented. Must be overridden in subclass.
New translation strings:
Method %s must be overridden.
Method %s not implemented. Must be overridden in subclass.