WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#41681 closed defect (bug) (fixed)

i18n: Avoid using HTML tags in translation strings (wp-admin/includes/meta-boxes.php)

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: administration Cc:

Description

This patch removes HTML <b> tags from translation strings.

Replacing: Uploaded on: <b>%1$s</b>

With: Uploaded on: %s

The patch also rewrites the code abandoning the $datef and $stamp parameters. They are only used once. We don't need to declare them, we can do the same without declaring those params.

Attachments (2)

41681.png​ (6.0 KB) - added by ramiy 8 years ago.
41681.patch​ (1.1 KB) - added by ramiy 8 years ago.

Download all attachments as: .zip

Change History (5)

@ramiy
8 years ago

@ramiy
8 years ago

#1 @ramiy
8 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
8 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41910:

I18N: Remove <b> tag from a translatable string in post_submit_meta_box().

Props ramiy.
Fixes #41681.

Note: See TracTickets for help on using tickets.