WordPress.org

Make WordPress Core

Opened 4 weeks ago

Last modified 3 weeks ago

#41694 reviewing defect (bug)

i18n: Avoid using HTML tags in translation strings (wp-signup.php)

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch
Focuses: Cc:

Description

The old translation string:

<a href="%1$s">%2$s</a> is your new site. <a href="%3$s">Log in</a> as &#8220;%4$s&#8221; using your existing password.

Is using <a href="%1$s">%2$s</a>. This can be replaced with a simple %1$s moving the HTML tags out of the string. Making is much easier for translation, especially in RTL languages like Hebrew where bi-directional languages are difficult to handle.

Attachments (2)

41694.png (19.7 KB) - added by ramiy 4 weeks ago.
41694.patch (853 bytes) - added by ramiy 4 weeks ago.

Download all attachments as: .zip

Change History (5)

@ramiy
4 weeks ago

@ramiy
4 weeks ago

#1 @ramiy
4 weeks ago

Old string:

  • <a href="%1$s">%2$s</a> is your new site. <a href="%3$s">Log in</a> as &#8220;%4$s&#8221; using your existing password.

New string:

  • %1$s is your new site. <a href="%2$s">Log in</a> as &#8220;%3$s&#8221; using your existing password.

#2 @ramiy
4 weeks ago

  • Keywords has-patch added

Related: #41645

#3 @SergeyBiryukov
3 weeks ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing
Note: See TracTickets for help on using tickets.