WordPress.org
Get WordPress

Make WordPress Core

Opened 9 years ago

Closed 9 years ago

#41695 closed defect (bug) (fixed)

i18n: Avoid using HTML tags in translation strings (wp-admin/includes/class-theme-upgrader.php)

Reported by: ramiy Owned by: SergeyBiryukov
Priority: normal Milestone: 4.9
Component: I18N Version:
Severity: normal Keywords: has-patch
Cc: Focuses: administration

Description

This patch removes HTML <strong> tags from translation strings. Replacing <strong>%s</strong> with %s moving the HTML tags outside.

Old string:

  • <strong>The parent theme could not be found.</strong> You will need to install the parent theme, <strong>%s</strong>, before you can use this child theme.

New string:

  • <strong>The parent theme could not be found.</strong> You will need to install the parent theme, %s, before you can use this child theme.

Attachments (2)

41695.png​ (21.0 KB ) - added by ramiy 9 years ago.
41695.patch​ (1.6 KB ) - added by ramiy 9 years ago.

Download all attachments as: .zip

Change History (5)

@ramiy
9 years ago

@ramiy
9 years ago

#1 @ramiy
9 years ago

  • Focuses administration added
  • Keywords has-patch added

#2 @SergeyBiryukov
9 years ago

  • Milestone Awaiting Review → 4.9
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#3 @SergeyBiryukov
9 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 41909:

I18N: Remove <strong> tag from a translatable string in Theme_Upgrader::install_strings().

Props ramiy.
Fixes #41695.

Note: See TracTickets for help on using tickets.