WordPress.org

Make WordPress Core

Opened 3 months ago

Closed 2 months ago

#41704 closed defect (bug) (fixed)

Use a consistent title for "Add Media" button and "Insert Media" window

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 3.5
Component: Media Keywords: has-patch needs-testing
Focuses: ui, administration Cc:

Description

One of ru_RU forum moderators noticed a discrepancy between "Add Media" button and "Insert Media" window and raised a point that they should have the same title for consistency.

Technically introduced in [21683]. Before 3.5, the window was titled "Add Media", and the button was a link with an "Upload/Insert" link text and "Add Media" as a title attribute: #19956.

Attachments (1)

media.diff (576 bytes) - added by danieltj 3 months ago.
Changes string from Insert to Add to match button.

Download all attachments as: .zip

Change History (7)

@danieltj
3 months ago

Changes string from Insert to Add to match button.

#1 @danieltj
3 months ago

  • Keywords has-patch needs-testing added

@SergeyBiryukov I've changed the string from Insert to Add. It looks like this string is used in a few places and seems to have updated throughout the UI nicely where it was used.

#2 @SergeyBiryukov
3 months ago

  • Focuses ui administration added
  • Milestone changed from Awaiting Review to 4.9

This ticket was mentioned in Slack in #core by danieltj. View the logs.


3 months ago

This ticket was mentioned in Slack in #core-media by joemcgill. View the logs.


2 months ago

#5 @joemcgill
2 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

I'm not opposed to changing this string if it helps translations be more consistent.

#6 @SergeyBiryukov
2 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 41383:

Media: Rename "Insert Media" window title to "Add Media" for consistency with the "Add Media" button.

Props danieltj.
Fixes #41704.

Note: See TracTickets for help on using tickets.