WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 7 years ago

#41705 closed defect (bug) (fixed)

i18n: Avoid using HTML tags in translation strings in upgrade classes

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-patch needs-testing 2nd-opinion
Focuses: administration Cc:

Description

This patch removes HTML tags from translation strings. Replacing <span class="code">%s</span> with %s moving the HTML tags outside the string.

Attachments (2)

41705.png​ (40.4 KB) - added by ramiy 8 years ago.
41705.patch​ (5.3 KB) - added by ramiy 8 years ago.

Download all attachments as: .zip

Change History (5)

@ramiy
8 years ago

@ramiy
8 years ago

#1 @ramiy
8 years ago

  • Keywords has-patch needs-testing 2nd-opinion added

#2 @SergeyBiryukov
8 years ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#3 @SergeyBiryukov
7 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 41908:

I18N: Remove <code> tags from translatable strings in Core_Upgrader, Language_Pack_Upgrader, Plugin_Upgrader, Theme_Upgrader.

Props ramiy.
Fixes #41705.

Note: See TracTickets for help on using tickets.