Opened 8 years ago
Last modified 6 weeks ago
#41711 new defect (bug)
Remove hAtom from core
| Reported by: |
|
Owned by: | |
|---|---|---|---|
| Milestone: | Awaiting Review | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Formatting | Keywords: | dev-feedback 2nd-opinion close |
| Focuses: | Cc: |
Description
We output hAtom in core and well, it's just not really needed anymore, so I'd like to get rid of it.
Here, amongst other places:
Change History (6)
#3
in reply to:
↑ 2
@
8 years ago
- Keywords close added
Replying to swissspidy:
See #32336 and #32326. The big problem is that many themes use
hentryfor styling.
Also https://core.trac.wordpress.org/ticket/30783#comment:27 tl;dr: - hentry will *not* be removed from core
#4
@
8 years ago
- Keywords close removed
The big problem is that many themes use hentry for styling.
We can solve the by introducing a add_theme_support that allows themes to remove it automatically without needs all themes to add hacks like
<?php function _s_body_classes( $classes ) { // Adds a class of hfeed to non-singular pages. if ( ! is_singular() ) { $classes[] = 'hfeed'; } return $classes; } add_filter( 'body_class', '_s_body_classes' ); function _s_post_classes( $classes ) { if ( 'page' === get_post_type() ) { $classes = array_diff( $classes, array( 'hentry' ) ); } return $classes; } add_filter( 'post_class', '_s_post_classes' );
Did not mean to remove the close keyword but I don't agree it should be closed.
This ticket was mentioned in Slack in #themereview by grapplerulrich. View the logs.
8 years ago
#6
@
6 weeks ago
- Keywords close added
Hi @grapplerulrich,
The proposal to use add_theme_support() to manage this change was a thoughtful approach to handling the significant backward compatibility issue, especially concerning themes that rely on the .hentry class for styling.
Given this ticket has been stalled for years without a consensus around this, I recommend we re-add the close tag for now. 😃
Introduced in [8641] as a part of sticky posts. No reasoning for
hentryis mentioned in the ticket though: #7457.