Wrong Site ID in site-users.php

[pluus]

I’ve found a weird glitch in wp-admin/network/site-users.php.

Issue :: ​http://imgur.com/rhArDXv

Whenever I was trying to add a user to a site, it was complaining that the requested site doesn’t exist. While investigating it, I’ve found that the $id value changes after the user table is displayed.

Fixed :: ​http://imgur.com/HWERGkg

After disabling #270, the wrong id issue was fixed. All I can assume at this stage is that the function to display the user table is corrupting $id somehow.

Is this a known issue?

[pluus]

Since the table is a must have thing... I've replaced the following code
<input type="text" name="id" value="<?php echo esc_attr( $id ) ?>" />

with

<input type="text" name="id" value="<?php echo esc_attr( $_REQUEST [ 'id' ] ) ?>" />

to directly get the site id from the URL.

[desrosj]

Hey @pluus, welcome to Trac!

I was unable to reproduce the behavior that you described. When I am on wp-admin/network/site-users.php, the field has the correct ID.

Are you using any plugins when you see this behavior?

Also, in the page's output, there should be a localized JavaScript variable, current_site_id. Can you view source and see if that has the correct value in it?

[jeremyfelt]

I'm going to go ahead and close this as worksforme. @pluus, if you are still having this issue and can reproduce it without plugins activated, please feel free to comment and reopen if needed.

[pluus]

Sorry for the late reply. Please go ahead close it for now. I will investigate plugins the website is using. Thanks.