Changes between Version 1 and Version 2 of Ticket #41722, comment 17
- Timestamp:
- 10/10/2017 07:07:59 PM (8 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #41722, comment 17
v1 v2 6 6 - Added the same empty check for {{{$socket}}}, as done in [attachment:41722-sockets-fix.diff] for the {{{$port}}}. 7 7 8 Can we do the same for {{{$host}}}?In the first test, within {{{parse_db_host_data_provider()}}}, the empty string {{{DB_HOST}}} is expected to be parsed into a {{{null}}} {{{$host}}}. So this patch assumes that output for empty {{{$host}}}. It would be good to have others verifying that this is valid.8 In the first test, within {{{parse_db_host_data_provider()}}}, the empty string {{{DB_HOST}}} is expected to be parsed into a {{{null}}} {{{$host}}}. So this patch assumes that output for empty {{{$host}}}. It would be good to have others verifying that this is valid. 9 9 10 10 Update: we then could consider e.g.: