WordPress.org

Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #41722, comment 17


Ignore:
Timestamp:
10/10/2017 07:08:38 PM (2 years ago)
Author:
birgire
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41722, comment 17

    v2 v3  
    44
    55- Replace {{{assertEquals()}}} with {{{assertSame()}}}
    6 - Added the same empty check for {{{$socket}}}, as done in [attachment:41722-sockets-fix.diff] for the {{{$port}}}.
     6- Added the same empty check for {{{$host}}} and {{{$socket}}}, as done in [attachment:41722-sockets-fix.diff] for the {{{$port}}}.
    77
    88In the first test, within {{{parse_db_host_data_provider()}}}, the empty string {{{DB_HOST}}} is expected to be parsed into a {{{null}}} {{{$host}}}. So this patch assumes that output for empty {{{$host}}}. It would be good to have others verifying that this is valid.