WordPress.org
Get WordPress

Make WordPress Core

Opened 8 years ago

Closed 8 years ago

#41734 closed defect (bug) (fixed)

Specify JSON schema version used instead of indicating the latest version is supported.

Reported by: timothyblynjacobs's profile TimothyBlynJacobs Owned by: kadamwhite's profile kadamwhite
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.7
Component: REST API Keywords: has-patch commit
Focuses: rest-api Cc:

Description

Specify the $schema version as latest has been deprecated: ​https://github.com/json-schema-org/json-schema-spec/issues/216.

Beyond the fact that it is deprecated, this causes issues since core does not support v6 for example the way exclusiveMinimums work in v6 breaks v4.

Attachments (1)

41734.diff​ (6.5 KB) - added by TimothyBlynJacobs 8 years ago.

Download all attachments as: .zip

Change History (8)

@TimothyBlynJacobs
8 years ago

#1 @TimothyBlynJacobs
8 years ago

  • Keywords has-patch added

This ticket was mentioned in ​Slack in #core-restapi by timothybjacobs. ​View the logs.
8 years ago

#3 @danielbachhuber
8 years ago

+1

We've been lazy in our definition of JSON Schema to date, so it's worthwhile to be more formal about it.

This ticket was mentioned in ​Slack in #core-restapi by timothybjacobs. ​View the logs.
8 years ago

#5 @kadamwhite
8 years ago

  • Milestone changed from Awaiting Review to 4.9
  • Owner set to kadamwhite
  • Status changed from new to accepted

#6 @kadamwhite
8 years ago

  • Keywords commit added

#7 @kadamwhite
8 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 41731:

REST API: Specify specific json-schema version.

Explicitly specifies that the REST API uses JSON Schema draft-04,
as JSON Schema has deprecated versionless schema URIs and recommends
the use of a specific draft version.

Props @TimothyBlynJacobs
Fixes #41734

Note: See TracTickets for help on using tickets.