get_sites() returns an integer when 'count' is passed as a query var

[ocean90]

But the current @return tag only mentions an array.

[ocean90]

In 41331:

Multisite: Clarify return type of get_sites() when 'count' is passed as a query var.

Fixes #41789.

[johnbillion]

In 41333:

Multisite: More specificity for the get_sites() documentation.

See #41789

[ocean90]

@johnbillion That specificity is incorrect. get_sites() can also return an array of IDs.
Also, why didn't you update get_sites()? And while we're on it, we should probably make the docs consistent across all the query classes.

[johnbillion]

Let's try again.

[jeremyfelt]

How about:

array|int Defaults to list of WP_Site objects. A list of site ids when 'fields' is set to 'ids'. The number of sites when 'count' is passed as a query var.

• On WP_Site_Query's query() and get_sites() and in the get_sites() function.
• Similarly with networks on WP_Network_Query's query() and get_networks() and in the get_networks() function.

[melchoyce]

@johnbillion Still trying to get this one in 4.9?

[jeremyfelt]

Let's go with 41789.diff​ for 4.9. We can address the documentation of other queries in another ticket.

[jeremyfelt]

In 41912:

Multisite: Document all return types in get_sites().

Adds more complete documentation to get_sites() and the corresponding methods in WP_Site_Query.

Fixes #41789.