WordPress.org

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

#41798 closed enhancement (fixed)

Change "Hey, did you hear" in text strings?

Reported by: birgire Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.8.1
Component: Text Changes Keywords: has-patch
Focuses: Cc:

Description

I was translating these strings:

Hey, did you hear we have a &#8220;Custom HTML&#8221; widget now? You can find it by pressing the &#8220;<a class="add-widget" href="#">Add a Widget</a>&#8221; button and searching for &#8220;HTML&#8221;. Check it out to add some custom code to your site!
Hey, did you hear we have a &#8220;Custom HTML&#8221; widget now? You can find it by pressing the &#8220;<a class="add-widget" href="#">Add a Widget</a>&#8221; button and searching for &#8220;HTML&#8221;. Check it out to add some custom code to your site!

when I started to wonder if we should change "Hey, did you hear", as not everyone can hear.

Would it be more inclusive to have "Hey, did you know that" ?

It was just a thought, that I decided to post here.

Attachments (2)

41798.diff (1.6 KB) - added by mrasharirfan 3 years ago.
Updated the help text according to the description.
41798.2.diff (1.6 KB) - added by danieltj 3 years ago.
Added a patch to make the string a bit less informal.

Download all attachments as: .zip

Change History (7)

#1 @SergeyBiryukov
3 years ago

  • Milestone changed from Awaiting Review to 4.9

Makes sense to me.

#2 @Soean
3 years ago

  • Keywords needs-patch added

@mrasharirfan
3 years ago

Updated the help text according to the description.

#3 @mrasharirfan
3 years ago

  • Keywords has-patch added; needs-patch removed

https://i.imgur.com/0lkjpUe.png

#4 @danieltj
3 years ago

If we're going to change this, shouldn't we make it slightly less personal and have did you know that... instead?

Just seems a bit too informal considering what it actually is. Personal preference of course, just my £0.02p.

edit

I've added in my patch, Reworded it very slightly although I appreciate it doesn't make a huge difference.

Last edited 3 years ago by danieltj (previous) (diff)

@danieltj
3 years ago

Added a patch to make the string a bit less informal.

#5 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41577:

Customize: Tweak "New Custom HTML Widget" pointer text to be a bit less informal and more inclusive.

Props birgire, mrasharirfan, danieltj.
Fixes #41798.

Note: See TracTickets for help on using tickets.