WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41801, comment 23


Ignore:
Timestamp:
01/09/2019 07:39:30 PM (14 months ago)
Author:
pbiron
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41801, comment 23

    initial v1  
    11I was going to update the patch per [[https://wordpress.slack.com/archives/C02SX62S6/p1546978156206900|our discussion yesterday on Slack]], however there is another "gotcha" with using the list(s) in `wp_get_ext_types()` as the "source of truth": that function applies the `ext2type` filter to those lists before returning.   Hence, unless we temporarily unhook `ext2type` we're not guaranteed to get those lists as the defaults.
    22
    3 And temporarily unhooking (and later rehooking) **every callback** for that hook is nasty business.  I've done the following in plugins before, but I'm reluctant to do it in core (would set a bad precedence):
     3And temporarily unhooking (and later rehooking) **every callback** for that hook is nasty business.  I've done the following in plugins before, but I'm reluctant to do it in core (would set a bad precedent):
    44
    55{{{#!php