WordPress.org

Make WordPress Core

Opened 2 months ago

Closed 2 months ago

Last modified 2 months ago

#41817 closed task (blessed) (fixed)

Remove oEmbed support for Vine

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.1
Component: Embeds Keywords: close
Focuses: Cc:

Description

oEmbed support for Vine.co should be removed for the following reasons:

  • Vine effectively shut down in December 2016, although it does still exist in a read-only state (ref).
  • The oEmbed endpoint no longer works and returns a 404 (ref).
  • Developer documentation for Vine has been removed (ref).

Support was introduced three short years ago in #30426.

Attachments (2)

41817.0.diff (1.7 KB) - added by danieltj 2 months ago.
Removed the Vine oEmbed.
41817.2.diff (2.9 KB) - added by danieltj 2 months ago.
Removes all instances of Vine in Core

Download all attachments as: .zip

Change History (10)

@danieltj
2 months ago

Removed the Vine oEmbed.

#1 @danieltj
2 months ago

  • Keywords has-patch needs-testing added; needs-patch removed

Removed the Vine oEmbed from Core. Essentially reversed the commit to add it in.

This ticket was mentioned in Slack in #core by danieltj. View the logs.


2 months ago

@danieltj
2 months ago

Removes all instances of Vine in Core

#4 @danieltj
2 months ago

  • Keywords needs-refresh removed

Added a new patch which removes all instances of Vine within Core except themes (will need a separate ticket for those). Thanks for flagging up the Press This code @netweb! I've done a search in the entire code base to make sure there's nothing else and seem to have got everything.

If anyone can do a test for me, please do!

#5 @netweb
2 months ago

There will be some oEmbed tests added on Monday in #41784 which will be 👌🏻

#6 @johnbillion
2 months ago

  • Owner set to johnbillion
  • Resolution set to fixed
  • Status changed from new to closed

In 41347:

Embeds: Remove support for oEmbedded videos from Vine.

  • Vine effectively shut down in December 2016.
  • The oEmbed endpoint no longer works and returns a 404.
  • Developer documentation for Vine has been removed.

Fixes #41817

#7 follow-up: @johnbillion
2 months ago

@danieltj I'm so sorry, I missed your props in [41347] :-(

#8 in reply to: ↑ 7 @danieltj
2 months ago

  • Keywords close added; has-patch needs-testing removed

Replying to johnbillion:

@danieltj I'm so sorry, I missed your props in [41347] :-(

Ah, don't worry about it. If you could do me a favour and check out some of my other waiting patches that'd be awesome. Thanks for committing though! :)

Note: See TracTickets for help on using tickets.