#41817 closed task (blessed) (fixed)
Remove oEmbed support for Vine
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 4.9 | Priority: | normal |
Severity: | normal | Version: | 4.1 |
Component: | Embeds | Keywords: | close |
Focuses: | Cc: |
Description
oEmbed support for Vine.co should be removed for the following reasons:
- Vine effectively shut down in December 2016, although it does still exist in a read-only state (ref).
- The oEmbed endpoint no longer works and returns a 404 (ref).
- Developer documentation for Vine has been removed (ref).
Support was introduced three short years ago in #30426.
Attachments (2)
Change History (10)
#1
@
7 years ago
- Keywords has-patch needs-testing added; needs-patch removed
Removed the Vine oEmbed from Core. Essentially reversed the commit to add it in.
This ticket was mentioned in Slack in #core by danieltj. View the logs.
7 years ago
#3
@
7 years ago
- Keywords needs-refresh added
Vine should also be removed from https://core.trac.wordpress.org/browser/trunk/src/wp-admin/includes/class-wp-press-this.php#L458
#4
@
7 years ago
- Keywords needs-refresh removed
Added a new patch which removes all instances of Vine within Core except themes (will need a separate ticket for those). Thanks for flagging up the Press This code @netweb! I've done a search in the entire code base to make sure there's nothing else and seem to have got everything.
If anyone can do a test for me, please do!
#6
@
7 years ago
- Owner set to johnbillion
- Resolution set to fixed
- Status changed from new to closed
In 41347:
#8
in reply to:
↑ 7
@
7 years ago
- Keywords close added; has-patch needs-testing removed
Replying to johnbillion:
@danieltj I'm so sorry, I missed your
props
in [41347] :-(
Ah, don't worry about it. If you could do me a favour and check out some of my other waiting patches that'd be awesome. Thanks for committing though! :)
Removed the Vine oEmbed.