WordPress.org

Make WordPress Core

Opened 13 days ago

Closed 10 days ago

#41829 closed enhancement (fixed)

Customizer: Deprecate "Your theme supports..."

Reported by: melchoyce Owned by:
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch
Focuses: ui Cc:

Description

It's pretty rare that a theme these days wouldn't support a static front page, or a menu. Rather than telling folks their theme does support something they'd expect to be supported, let's only tell people when their theme doesn't support something.

Attachments (2)

add-help-reading-options-help-tab-text-as-homepage-settings-section-description.png (145.0 KB) - added by westonruter 10 days ago.
41829.0.diff (1.5 KB) - added by westonruter 10 days ago.

Download all attachments as: .zip

Change History (8)

@westonruter
10 days ago

#1 @westonruter
10 days ago

  • Keywords has-patch added

@melchoyce what about add-help-reading-options-help-tab-text-as-homepage-settings-section-description.png to add help tab text from Reading Options as description for Homepage Settings section in Customizer?

Note in this case here we don't need the link to Pages since the stubs can be created inline.

#2 @melchoyce
10 days ago

Let's do it! The more explanation the better.

#3 @westonruter
10 days ago

In 41364:

Customize: Re-use homepage settings help tab text from Reading Options admin screen in description for corresponding Customizer section.

Also remove "Static" reference in template name, missed in [41363].

See #41829.

#4 @westonruter
10 days ago

@melchoyce is there anywhere else we have to update that text? Every other mention of “theme supports” seems appropriate:

src/wp-includes/class-wp-customize-nav-menus.php:563:			$description = '<p>' . __( 'Your theme supports one menu. Select which menu you would like to use.' ) . '</p>';
src/wp-includes/class-wp-customize-nav-menus.php:566:			$description = '<p>' . sprintf( _n( 'Your theme supports %s menu. Select which menu appears in each location.', 'Your theme supports %s menus. Select which menu appears in each location.', $num_locations ), number_format_i18n( $num_locations ) ) . '</p>';
src/wp-includes/customize/class-wp-customize-nav-menu-item-control.php:125:					<span class="description"><?php _e( 'The description will be displayed in the menu if the current theme supports it.' ); ?></span>
src/wp-admin/includes/class-walker-nav-menu-edit.php:196:						<span class="description"><?php _e('The description will be displayed in the menu if the current theme supports it.'); ?></span>
src/wp-admin/nav-menus.php:612:			echo '<p>' . __( 'Your theme supports one menu. Select which menu you would like to use.' ) . '</p>';
src/wp-admin/nav-menus.php:614:			echo '<p>' .  sprintf( _n( 'Your theme supports %s menu. Select which menu appears in each location.', 'Your theme supports %s menus. Select which menu appears in each location.', $num_locations ), number_format_i18n( $num_locations ) ) . '</p>';

Otherwise this can be closed as fixed.

#5 @melchoyce
10 days ago

The menu stuff should covered if we tackle #40104, so I think we can close this one out and maybe revisit if that improvement doesn't make it into 4.9.

#6 @westonruter
10 days ago

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.