WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#41841 closed defect (bug) (fixed)

some more dit­togra­phies

Reported by: Presskopp Owned by: SergeyBiryukov
Milestone: 4.9 Priority: normal
Severity: normal Version: 4.9
Component: General Keywords: has-patch
Focuses: docs Cc:

Description

like in #41835, #41836 I ran another round of regex and found these:

'in in', 'this this', 'containing containing'

see following patch

Attachments (3)

41841.diff (2.0 KB) - added by Presskopp 2 years ago.
41841.2.patch (1.6 KB) - added by birgire 2 years ago.
Fix the "to to" cases - skipped the one in wp-includes/js/tinymce/tinymce.js
41841.3.patch (1.9 KB) - added by birgire 2 years ago.
Some more "being being", "called called" and "the the"

Download all attachments as: .zip

Change History (15)

@Presskopp
2 years ago

#1 @Presskopp
2 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 4.9

#3 @SergeyBiryukov
2 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 41353:

Docs: Remove "in in", "this this", and "containing containing" dittography from inline comments.

Props Presskopp.
Fixes #41841.

This ticket was mentioned in Slack in #core by sergey. View the logs.


2 years ago

@birgire
2 years ago

Fix the "to to" cases - skipped the one in wp-includes/js/tinymce/tinymce.js

#5 @birgire
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

Patched some more for the "to to" case but I skipped the one in /wp-includes/js/tinymce/tinymce.js

Last edited 2 years ago by birgire (previous) (diff)

#6 @SergeyBiryukov
2 years ago

In 41354:

Docs: Remove "to to" dittography from inline comments.

Props birgire.
See #41841.

#7 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41355:

Docs: Remove "since since" and "one one" dittography from inline comments.

Fixes #41841.

@birgire
2 years ago

Some more "being being", "called called" and "the the"

#8 @birgire
2 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

The last patch fixes:

"being being"
"called called"
"the the"

I played with variations of:

sudo grep -iE " ([a-z].*?) \1 " -R src  | less

I found some funny duplications, like:

src/wp-includes/class-json.php:        
// oh please oh please oh please oh please oh please

src/wp-includes/class-wp-editor.php:                     
* For people who really REALLY know what they're doing with TinyMCE

that I skipped.

Also skipped these ones:

src/wp-includes/js/tinymce/tinymce.js:        
// Resize container container if minSize was changed

src/wp-includes/js/tinymce/tinymce.js:      
// TODO: Move this to a separate range utils class since it's it's logic is present in Selection as well.


src/wp-content/themes/twentyseventeen/assets/js/html5.js:  
/** The id for the the documents expando */

src/wp-content/themes/twentysixteen/genericons/README.md:
FontCustom is a powerful commandline tool which which bakes icon fonts from the SVG source files. It's the tool Genericons is built on, and it provides highly accurate and perfectly crisp icons, *provided all SVGs have the same pixel height*.

#9 @SergeyBiryukov
2 years ago

The SimplePie fix appears to be applied upstream and should be included once the WP core version is updated next.

#10 @SergeyBiryukov
2 years ago

In 41357:

Twenty Fifteen: Remove "called called" dittography, missed in [41349].

Props birgire.
See #41841, #41836.

#11 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 41358:

Docs: Remove "being being" dittography from inline comments.

Props birgire.
Fixes #41841.

#12 @swissspidy
2 years ago

#41856 was marked as a duplicate.

Note: See TracTickets for help on using tickets.