WordPress.org

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#41851 closed task (blessed) (fixed)

Avoid more test skipping for situations that are actually errors or failures

Reported by: johnbillion Owned by: johnbillion
Milestone: 4.9 Priority: normal
Severity: normal Version:
Component: Build/Test Tools Keywords:
Focuses: Cc:

Description

This is a follow-up to #40533 for the 4.9 cycle.

Some tests contain calls to markTestSkipped() as a result of situations such as incorrect test data or unsuitable test environments. If the test data isn't valid or the environment is not capable of supporting the test then the test should fail, otherwise the tests are not reliable.

Change History (5)

#1 @johnbillion
4 years ago

In 41367:

Build/Test Tools: Convert more test skipping into hard failures.

See #41851

#2 @boonebgorges
4 years ago

@johnbillion The changes to Tests_Image_Meta seem too strong to me. WordPress can run in environments without the gd or exif extensions. If we want the tests to be portable - especially for cases where hosts want to run them in their own environments - then we should not make them fail because of non-essential PHP modules. (That's what phpunit --strict is for.)

If, on the other hand, we're going to decide that we want the tests to be maximally broad, and thus to have system requirements more stringent than WordPress itself, we should establish this as policy.

#3 @johnbillion
4 years ago

  • Keywords needs-patch added
  • Owner set to johnbillion
  • Status changed from new to accepted

@boonebgorges Agreed on the gd change. Thanks.

#4 @johnbillion
4 years ago

In 41647:

Build/Test tools: Partially revert [41367] as gd and exif aren't actually required to run WordPress.

See #41851

#5 @johnbillion
4 years ago

  • Keywords needs-patch removed
  • Resolution set to fixed
  • Status changed from accepted to closed
Note: See TracTickets for help on using tickets.