Make WordPress Core

Changes between Version 2 and Version 3 of Ticket #41859, comment 3


Ignore:
Timestamp:
12/04/2017 09:41:32 PM (8 years ago)
Author:
antonioeatgoat
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41859, comment 3

    v2 v3  
    11The patch uses by default some of the parameters used by Twenty Seventeen, however this upsets the theme, because there is a repeated nested span with the same class. So likely not the best way to achieve it, maybe changing the class name used by default in the function would be a solution.
    22
    3 Then it force the usage of a class to wrap the numbers, as {{{wp_link_pages()}}} does. I am not a big fun of the solution {{{ str_replace( '<a href="', '<a class="page-number" href="', $link ); }}}, however it's the only way that I see for now with the current structure of the function. It would be very nice to improve consistency between {{{paginate_links()}}} and {{{wp_link_pages()}}} because they use parameters and CSS class positions/names in a quite different way, despite they do basically the same thing.
     3Then it forces the usage of a class to wrap the numbers, as {{{wp_link_pages()}}} does. I am not a big fun of the solution {{{ str_replace( '<a href="', '<a class="page-number" href="', $link ); }}}, however it's the only way that I see for now with the current structure of the function. It would be very nice to improve consistency between {{{paginate_links()}}} and {{{wp_link_pages()}}} because they use parameters and CSS class positions/names in a quite different way, despite they do basically the same thing.