WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 5 years ago

#41869 closed defect (bug) (fixed)

Documentations was not proper.

Reported by: adnanlimdi's profile adnan.limdi Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Editor Keywords: needs-refresh has-patch
Focuses: docs Cc:

Description

Add static keyword and add functions Descriptions.

Attachments (1)

41869.patch​ (1.2 KB) - added by adnan.limdi 7 years ago.
Add static keyword in functions descriptions and add missing functions descriptions.

Download all attachments as: .zip

Change History (9)

@adnan.limdi
7 years ago

Add static keyword in functions descriptions and add missing functions descriptions.

#1 @SergeyBiryukov
7 years ago

  • Component changed from Administration to Editor
  • Focuses docs added

#2 @ramiy
7 years ago

  • Keywords has-patch added

#3 @adnan.limdi
7 years ago

#41868 was marked as a duplicate.

This ticket was mentioned in ​Slack in #core by noisysocks. ​View the logs.
5 years ago

#5 @dinhtungdu
5 years ago

  • Keywords needs-refresh added

@adnanlimdi Thanks for the patch. According to the discussion in Slack #core today, this patch needs an update:

  • Using tab instead of space.
  • This patch can't be applied cleanly.
  • The descriptions could be more descriptive.
Version 0, edited 5 years ago by dinhtungdu (next)

#6 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#7 @SergeyBiryukov
5 years ago

Per the ​documentation standards:

@static
Note: This tag has been used in the past, but should no longer be used.
Just using the static keyword in your code is enough for PhpDocumentor on PHP5 to recognize static variables and methods, and PhpDocumentor will mark them as static.

#8 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47023:

Docs: Add missing descriptions and @return tags for _WP_Editors::get_mce_locale() and ::get_baseurl().

Props adnan.limdi.
Fixes #41869.

Note: See TracTickets for help on using tickets.