WordPress.org

Make WordPress Core

Opened 7 days ago

Last modified 6 minutes ago

#41870 new task (blessed)

Code Editor: Add grunt task for building new CodeMirror bundles from external dependencies

Reported by: westonruter Owned by:
Milestone: 4.9 Priority: high
Severity: normal Version:
Component: Build/Test Tools Keywords: needs-patch
Focuses: javascript Cc:

Description (last modified by westonruter)

After [41376] for #12423, it would be ideal if the CodeMirror bundling logic (via browserify) could be added as part of core. In this way, the external dependencies (CodeMirror and the linter linraries) can be managed by NPM. For now, just the minified bundles are being included.

The logic used in the Better Code Editing plugin for creating the bundles can be seen here: https://github.com/WordPress/better-code-editing/pull/92/files

Depends on #40894 which replaces Browserify with Webpack in core.

Additionally, the linters are currently being included as separate assets. They are not being minified, other than they are already minified as distributed. These could either benefit from additional uglification or bundling with codemirror if they are not going to be enqueued separately. The same goes for the htmlhint-kses script.

Change History (7)

#1 @westonruter
7 days ago

  • Description modified (diff)

#2 @westonruter
7 days ago

  • Description modified (diff)

#3 @westonruter
107 minutes ago

  • Priority changed from normal to high

Bumping priority to high for visibility and alignment with 4.9 goals, and given proximity to beta 1 deadline.

#4 @westonruter
8 minutes ago

  • Type changed from enhancement to task (blessed)

#5 @westonruter
7 minutes ago

CodeMirror 5.30.0 was just released so this would be a good update to test the integration of a build process.

#6 @westonruter
7 minutes ago

  • Focuses javascript added

#7 @westonruter
6 minutes ago

  • Component changed from External Libraries to Build/Test Tools
Note: See TracTickets for help on using tickets.