WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #41872, comment 3


Ignore:
Timestamp:
09/13/2017 06:43:32 PM (4 years ago)
Author:
westonruter
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #41872, comment 3

    initial v1  
    1 @afercia the code changes look good, other than the jQuery for obtaining `.CodeMirror-code`. This can be simplified by just accessing `control.editor.codemirror.display.lineDiv`. Done in [attachment:41872.2.diff].
     1@afercia the code changes look good, other than the jQuery for obtaining `.CodeMirror-code`. This can be simplified by just accessing `editor.codemirror.display.lineDiv`. Done in [attachment:41872.2.diff].
    22
    33Otherwise, for the text changes and label additions, I'll defer to @melchoyce, @michelleweber, and @mizejewski.